Re: thanks for nothing - a look at the uninstaller

[Christophe Ponsard <christophe ponsard cetic be>]

Hello

Le 29/01/2014 21:35, Octavio Alvarez a écrit :
> If this was the fault of the installer/uninstaller I can assure you this
> is considered grave by anyone around, but we need to replicate the
> problem to find the root cause and provide a fix.
I had a look at this uninstaller part of this installer file:
https://git.gnome.org/browse/dia/tree/installer/win32/dia.nsi
there seems to be a recursive rm loop in the uninstall part

if (by mistake) dia was installed in "C:\Programs Files" rather than  
"C:\Programs Files\dia"
then I suspect that the uninstaller could delete the whole "C:\Programs 
Files" and not only the dia files in there
actually I tried on a fake directory and I could reproduce this behavior
note the uninstall directory is shown at the first step of uninstall 
(but could be missed)
later the uninstaller asks for confirmation for directory removal
however at this stage the files are already deleted so I miss the point 
of this check
in addition for the above scenario to happen, the user should however 
explicitly change the default dir which is safe

hope this helps and let contributors more expert than me in NSIS dig 
further and decide if further robustification is needed

christophe (convinced dia user and shape contributor a long time ago)