Re: Refactoring app/disp_callbacks.c:ddisplay_canvas_event.c

[Hans Breuer <hans breuer org>]

Am 23.06.2008 11:38, Andrew M. Botros schrieb:
> I am currently working on refactoring
> app/disp_callbacks.c:ddisplay_canvas_event.c, I pulled most of the code out,
> I write just a few lines of new code to keep things working and tidy. 
Without looking at the changes it is very hard to judge, but if your 
"pulling out" means moving around I think you are on the right track.

> I wonder if that's what you needed to be done. 
I think it should be common practice to make the code more understandable 
and maintainable before adding new functionality, if that is what you are 
wondering about.

> I also restructured some of the
> code in the same file, just tabs and stuff like that, and as I didn't find
> any coding guidelines for dia, I wonder if that might annoy anybody. 
Dia's source really has some sometimes annoying lack of consistency in 
style, but again without actually seeing your changes it is hard to say if 
you are increasing or decreasing this ;)

> And actually was thinking why don't we have coding guidelines for dia..?
I think it would be best to find some well established coding style and 
only slightly adapt it to Dia, but until now I could not find one.

> It wasn't the easiest thing for me to find where the brace starts and
> ends...
Yeah this is one of the most inconsitent things in Dia. The thing I find 
most annoying is putting the starting brace as the same line as the 
function prototype. Within implementations I think having the starring 
brace at the same line as the condition is more common.

        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert