Re: Integrated UI layers patch

[Hans Breuer <hans breuer org>]

Am 11.07.2008 21:22, Patrick Hallinan schrieb:
> On Fri, 2008-07-11 at 20:58 +0200, Hans Breuer wrote:
>  
> > I have tried your patch as well, but it needs some work before it can be 
> > commited. It first crashed on me due to uninitialized 
> > LayerDialog::diagram_omenu. I worked around it by using
> >         g_new0 (struct LayerDialog, 1);
> > but afterwards there are warnings from Gtk+. Obviously the whole option 
> > menu to select the diagram in the layer dialog does not make sense for the 
> > integrated case.
>
> What did you do to get it to crash on the NULL
> LayerDialog::diagram_omenu?
It was not the NULL crashing it, as written above: it was the 
_uninitialized_ data (and the G_ENABLE_DEBUG version of GLib and Gtk+). 
NULL initialized I get complains from Gtk about not having an option menu.

> > > I was thinking of making the layer view narrower by having two rows of
> > > buttons:
> > >
> > >   ------------------
> > >   | Add   | Delete |
> > >   ------------------  
> > >   | Up    | Down   |
> > >   ------------------  
> > >
> > > But removing the labels would do the same thing.  Which would you
> > > prefer?
> > Removing the labels.
> >
> > > What do you think of renaming layer_dialog.* to layer_view.*?
> > Please lets do taht after the patch is commited to SVN.
>
> Are you committing your not-so-crashing patch to SVN?
Better not because ...
> I know that there are a LOT of gtk warnings.  I was planning to work on
> those after layer stuff was roughed out.
... every gtk+/glib warning is a potential crash and I really don't like to 
destabilze the version in SVN. (I barely have the time to fix already 
commited bugs ;-))

        Hans

-------- Hans "at" Breuer "dot" Org -----------
Tell me what you need, and I'll tell you how to
get along without it.                -- Dilbert