Re: Solaris 2.6 finite() prototype

[Andrew Halper <ashalper acm org>]

Cyrille Chepelov wrote:

> > I'll try to make an unobtrusive patch to fix it.
>
> Just add a configure.in test for the presence of ieeefp.h, and then include
> ieeefp.h if HAVE_IEEEFP in the files which use finite(). You don't need to
> apologise for using Solaris :-). It's a matter of

OK.  Got in the habit of being a platform apologist over many years of
trying to keep DG/UX M88Ks on life-support. :)

>         AC_CHECK_HEADERS(ieeefp.h)
>         (check that autoheader really includes a HAVE_IEEEFP variable then),
> and then #ifdef HAVE_IEEEFP (_H ?), do the right thing (it can't hurt to
> include both ieeefp.h and math.h on platform which have both but have
> finite() in math.h, anyway)

Patch attached.  Let me know if there are problems.

Andy

diff -r -c dia-ieeefp/configure.in dia/configure.in
*** dia-ieeefp/configure.in     Fri Aug 10 15:56:52 2001
--- dia/configure.in    Wed Aug  1 19:02:07 2001
***************
*** 281,287 ****
  dnl Checks for header files.
  AC_HEADER_DIRENT
  AC_HEADER_STDC
! AC_CHECK_HEADERS(stddef.h fcntl.h unistd.h ieeefp.h)
  
  dnl Checks for typedefs, structures, and compiler characteristics.
  AC_C_CONST
--- 281,287 ----
  dnl Checks for header files.
  AC_HEADER_DIRENT
  AC_HEADER_STDC
! AC_CHECK_HEADERS(stddef.h fcntl.h unistd.h)
  
  dnl Checks for typedefs, structures, and compiler characteristics.
  AC_C_CONST
diff -r -c dia-ieeefp/lib/geometry.h dia/lib/geometry.h
*** dia-ieeefp/lib/geometry.h   Fri Aug 10 15:57:10 2001
--- dia/lib/geometry.h  Fri May 25 18:11:48 2001
***************
*** 18,34 ****
  #ifndef GEOMETRY_H
  #define GEOMETRY_H
  
- #include <config.h>
- 
  #include <glib.h>
  #include <math.h>
- /* Solaris 2.4, 2.6, probably 2.5.x, and possibly others prototype
-    finite() in ieeefp.h instead of math.h.  finite() might not be
-    available at all on some HP-UX configurations (in which case,
-    you're on your own). */
- #ifdef HAVE_IEEEFP_H
- #include <ieeefp.h>
- #endif
  
  #ifdef _MSC_VER
     /* there are some things more in the gcc headers */
--- 18,25 ----