Re: Fix wrong FSF's address in in source files

[Claudio Saavedra <csaavedra gnome org>]

On Fri, 2014-01-31 at 17:03 +0200, Claudio Saavedra wrote:
> On Fri, 2014-01-31 at 14:44 +0100, Daniel Mustieles García wrote:
> > Hi all,
> >
> > I've commited all the remaining patches about this issue. If you notice
> > there is something wrong, please email me to fix it.

Other modules are broken too. It seems to me from inspecting the
breakage that whatever script you used to replace the address in the
sources fails whenever there are two instances of the text to be removed
in the same file, as everything in between gets removed too.

I think you should have done a clean jhbuild build before pushing any
changes programatically to bugzilla. We should probably have a hard rule
about this to avoid these massive breakages from happening in the
future.

Claudio

> You broke ephy.
>
> https://git.gnome.org/browse/epiphany/diff/embed/ephy-embed.c?id=d1a500a86767210ebae8150f0713c602141e2477
>
> I reverted your patch. If you want this fixed post a patch to bugzilla
> next time.
>
> Claudio
>
> > Many thanks to all of you for your comments and special thanks to Andika
> > Triwidada for his help with this issue.
> >
> > Andika: now we can close bugs in bugzilla, so I'll start doing so this
> > afternoon. If a maintainer doesn't agree with the patch commited, just
> > reopening the bug should be enough to get noticed about it.
> >
> > Cheers!
> >
> >
> > 2014-01-29 Olav Vitters <olav vitters nl>:
> >
> > > On Wed, Jan 29, 2014 at 10:55:08AM +0100, Daniel Mustieles García wrote:
> > > > I've created several patches to fix wrong FSF's address in source files
> > > > headers. There are several modules affected by this module. You can see
> > >
> > > Nice initiative!
> > >
> > >
> > > --
> > > Regards,
> > > Olav
> > > _______________________________________________
> > > desktop-devel-list mailing list
> > > desktop-devel-list gnome org
> > > https://mail.gnome.org/mailman/listinfo/desktop-devel-list
> > _______________________________________________
> > desktop-devel-list mailing list
> > desktop-devel-list gnome org
> > https://mail.gnome.org/mailman/listinfo/desktop-devel-list
>
>
> _______________________________________________
> desktop-devel-list mailing list
> desktop-devel-list gnome org
> https://mail.gnome.org/mailman/listinfo/desktop-devel-list