Re: Module Proposal: Zeitgeist

On Mon, Apr 26, 2010 at 2:01 AM, Cody Russell <bratsche gnome org> wrote:
> Eh, github's pull requests are not really the same as a code review
> system.  At least last time I looked at it.  You do a pull request and
> the person you're requesting basically just gets a message that says,
> "Hey dude, check out my awesome code!"  There isn't a nice UI for doing
> the code review, with diffs that can be commented on and whatever.

Uhm, you're supposed to review commits. You get a pull request (or
just stumble upon a fork of particular interest) and go to view
related commits. Each commit allows you to review each and every line
of code. It even seems that's where gitorious got their UI from.

Patryk Zawadzki

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]