Re: Module Proposal: Zeitgeist

On Sun, 2010-04-25 at 19:01 -0500, Cody Russell wrote:
> On Sun, 2010-04-25 at 22:44 +0200, Patryk Zawadzki wrote:
> > On Sun, Apr 25, 2010 at 7:59 PM, Curtis Hovey <sinzui is verizon net>
> > wrote:
> > > My suggestion is to support the Zeitgeist's community's culture of
> > code
> > > reviews. GNOME does not have an official code review tool. Neither
> > does
> > > GitHub, which is why projects that host in GitHub also use Launchpad
> > for
> > > code reviews.
> > 
> > Actually this is not true. GitHub lets you review any commit and the
> > usual workflow is fork → commit → request pull → get review. 
> Eh, github's pull requests are not really the same as a code review
> system.  At least last time I looked at it.  You do a pull request and
> the person you're requesting basically just gets a message that says,
> "Hey dude, check out my awesome code!"  There isn't a nice UI for doing
> the code review, with diffs that can be commented on and whatever.

I cannot say if it is nice but github have since some time option to
comment code/diffs.


Attachment: signature.asc
Description: This is a digitally signed message part

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]