Re: gnome-keyring should use DBus for discovery

[Nate Nielsen <nielsen-list memberwebs com>]

Alexander Larsson wrote:
> On Sun, 2007-02-11 at 04:38 +0000, Nate Nielsen wrote:
>> I've put together a patch which uses DBus to discover
>> gnome-keyring-daemon and find the appropriate socket to communicate on:
>>
>> http://bugzilla.gnome.org/show_bug.cgi?id=400956
>>
>> Any objections to me adding this into gnome-keyring?
> 
> In some cases gnome-keyring will be running before both dbus and
> seahorse-agent, such as a typical pam-keyring setup. In that case we
> must communicate via an environment variable. 
> 
> I guess we could additionally use dbus to find the daemon, but this must
> be done after looking at the env var. 

Done and committed.

> I don't like using dbus-glib-1. That is an ABI unstable library that we
> don't want to use at this level of the stack. (It would make all gnome
> apps depend on an unstable library...) The way I solve this in gvfs is
> to have a copy-paste of the mainloop integration (actually I made my own
> version).

This is a bummer as it added several hundred lines of hard-to-debug code
into gnome-keyring-daemon.

FWIW, gnome-vfs currently depends on dbus-glib-1.

> Also, avoid c++ style comments.

Whoops.

Nate Nielsen