Re: gnome-keyring should use DBus for discovery

[Alexander Larsson <alexl redhat com>]

On Sun, 2007-02-11 at 04:38 +0000, Nate Nielsen wrote:
> Currently gnome-keyring-daemon uses an environment variable to
> communicate its socket path to libgnome-keyring.
> 
> However this breaks down when applications are started early in the
> session. seahorse-agent is one such application. (Early in the session,
> it needs to setup environment variables to hook into SSH and GPG agents).
> 
> I've put together a patch which uses DBus to discover
> gnome-keyring-daemon and find the appropriate socket to communicate on:
> 
> http://bugzilla.gnome.org/show_bug.cgi?id=400956
> 
> Any objections to me adding this into gnome-keyring?

In some cases gnome-keyring will be running before both dbus and
seahorse-agent, such as a typical pam-keyring setup. In that case we
must communicate via an environment variable. 

I guess we could additionally use dbus to find the daemon, but this must
be done after looking at the env var. 

I don't like using dbus-glib-1. That is an ABI unstable library that we
don't want to use at this level of the stack. (It would make all gnome
apps depend on an unstable library...) The way I solve this in gvfs is
to have a copy-paste of the mainloop integration (actually I made my own
version).

Also, avoid c++ style comments.

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc 
                   alexl redhat com    alla lysator liu se 
He's a world-famous bohemian librarian in drag. She's a chain-smoking psychic 
vampire in the witness protection program. They fight crime!