[pitivi] widgets: Remove workaround for huge spinners
- From: Alexandru Băluț <alexbalut src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi] widgets: Remove workaround for huge spinners
- Date: Wed, 7 Mar 2018 00:06:47 +0000 (UTC)
commit d416f0e858e8c84da8132b4c56a622ca0cde9cae
Author: Alexandru Băluț <alexandru balut gmail com>
Date: Sun Mar 4 01:10:06 2018 +0100
widgets: Remove workaround for huge spinners
The Spinner widgets are not huge anymore if the upper limit is very
large, on least Gtk 3.24.
Fixes #2143
pitivi/utils/widgets.py | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/pitivi/utils/widgets.py b/pitivi/utils/widgets.py
index 2f848882..d8a4b64c 100644
--- a/pitivi/utils/widgets.py
+++ b/pitivi/utils/widgets.py
@@ -234,16 +234,12 @@ class NumericWidget(Gtk.Box, DynamicWidget):
with_slider = (lower is not None and lower > -reasonable_limit and
upper is not None and upper < reasonable_limit)
self.adjustment = Gtk.Adjustment()
- # Limit the limits, otherwise the widget appears huge.
- # Workaround https://bugzilla.gnome.org/show_bug.cgi?id=727294
- # If these hardcoded limits are a problem, the fix should be passing
- # the proper limits using the upper and lower parameters.
if upper is None:
- upper = GLib.MAXINT16
+ upper = GLib.MAXINT32
if lower is None:
- lower = GLib.MININT16
- self.adjustment.props.lower = max(GLib.MININT16, lower)
- self.adjustment.props.upper = min(upper, GLib.MAXINT16)
+ lower = GLib.MININT32
+ self.adjustment.props.lower = lower
+ self.adjustment.props.upper = upper
if with_slider:
self.slider = Gtk.Scale.new(
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]