[RFC] Balsa coding style

[Albrecht Dreß <albrecht dress arcor de>]

Hi all,

the balsa 'HACKING' file states

<snip>
The coding style used in Balsa currently is a bit of a mess.
</snip>

which is actually true... ;-)  I use Eclipse as development platform, and could not find a setting which 
displays /all/ files properly.

The same document states that the indent command

        indent -kr -i4 -psl

shall be used which seems to limit the line length to 72.  This was actually suitable for a 1024x768 screen, 
but seems to be too limited these days IMHO.  Actually, the short line wrapping makes reading the code very 
difficult.

What do you think about extending the indent statement above to a line length of, say, 132, and fixing the 
tab width to e.g. 4, i.e.:

        indent -kr -i4 -l132 -lc132 -ts4 -psl

and re-indent all files in the repository?

An other approach would be some re-factoring, e.g. replace complex statements like

<snip>
        if (!
            (key =
             get_key_from_name(ctx, name, FALSE, accept_low_trust, parent,
                               error))) {
</snip>

by

<snip>
        key = get_key_from_name(ctx, name, FALSE, accept_low_trust, parent,
                                                        error);
        if (key == NULL) {
</snip>

but this implies the risk to introduce errors.

Opinions?

Cheers
Albrecht.

Attachment: pgperegCZa9Nw.pgp
Description: PGP signature