Re: Balsa questions, feature requests, and a couple of bugs

[Peter Bloomfield <PeterBloomfield MindSpring com>]

On 2002.10.20 22:01 Christopher Culver wrote:
> On 2002.10.21 02:55 Peter Bloomfield wrote:
>> `Mailbox -> Commit' Current probably does what you're looking 
>> for. There have been other requests for automatic `commit'ing, 
>> say every x minutes, but I don't know whether it's scheduled 
>> for implementation.
> 
> I'd rather see immediate commiting, but if "Commit Current" is 
> the only thing to do in the meantime, it needs a key combo. 
> Otherwise, one ends up moving the mouse about the same as if 
> one just closed a mailbox and opened it. It would be nice if 
> the bulk of the program could be accessed by keyboard, perhaps 
> Sylpheed spoiled me too much.

You can already get to "Commit Current" with `alt-b' (to drop 
down the Mail_box menu) and `m' (mnemonic for "Commit Current"). 
The main window already has many keybindings--I don't know if 
there's one left over that could be used as an accelerator for 
committing.

Keyboard access is an issue for Balsa-2; it's getting better, but 
there are still some rough spots--please let us know of any more 
that you notice.

>> It seems that's not a bug--there's no key combo for `File -> 
>> Save'--perhaps there should be!
> 
> Indeed, I know of no other mailer that doesn't have one.

The compose window is much less keybound; the attached patch 
implements Ctrl-S as an accelerator for `File -> Save'. It's a 
diff against the BALSA_2 branch in current cvs, but should apply 
to any recent source tree. If nobody sees a problem with it, it 
should presumably be committed.

Peter
Index: src/sendmsg-window.c
===================================================================
RCS file: /cvs/gnome/balsa/src/sendmsg-window.c,v
retrieving revision 1.341.2.38
diff -u -r1.341.2.38 sendmsg-window.c
--- src/sendmsg-window.c	25 Sep 2002 20:44:26 -0000	1.341.2.38
+++ src/sendmsg-window.c	21 Oct 2002 15:25:11 -0000
@@ -211,8 +211,10 @@
     GNOMEUIINFO_ITEM_STOCK(N_("_Postpone"), NULL,
 			   postpone_message_cb, BALSA_PIXMAP_MENU_POSTPONE),
 #define MENU_FILE_SAVE_POS 8
-    GNOMEUIINFO_ITEM_STOCK(N_("_Save"), NULL,
-			   save_message_cb, BALSA_PIXMAP_MENU_SAVE),
+    { GNOME_APP_UI_ITEM, N_("_Save"),
+      N_("Save this message"),
+      save_message_cb, NULL, NULL, GNOME_APP_PIXMAP_STOCK,
+      BALSA_PIXMAP_MENU_SAVE, 'S', GDK_CONTROL_MASK, NULL },
 #define MENU_FILE_PRINT_POS 9
     GNOMEUIINFO_ITEM_STOCK(N_("Print..."), N_("Print the edited message"),
 			   print_message_cb, BALSA_PIXMAP_MENU_PRINT),