Re: balsa MDN reply patches (long, sorry...)

On 22.03.2001 12:04:01 Pawel Salek wrote:
> Thanks for the patch, I am sorry it took me so long to evaluate it but
> it seems it is pretty ok. I just have some minor comments concerning the

I am really glad if you like my work, so don't worry about time...

> programming style:
> - we use in balsa code slightly different indentation scheme.

Sorry, my fault. Is there any place where all these conventions are listed?

> - the rfc2298_address_equal is not bullet-proof. It could not find out
> that addresses
> Pawel Salek <>
> and
> are identical.

Hmmm, I thought libbalsa_address_to_gchar would remove everything except the
"real" address. So I faked a message from you ;-)) with the following header:

: From root@regulus.localdomain  Thu Mar 22 17:48:56 2001
: Return-Path: Pawel Salek <>
: Received: from localhost (root@localhost)
:         by regulus.localdomain (8.11.1/8.9.3) with ESMTP id f2MGmso04820
:         for <albrecht@localhost>; Thu, 22 Mar 2001 17:48:54 +0100
: Date: Thu, 22 Mar 2001 17:48:53 +0100 (CET)
: From: Pawel Salek <>
: Disposition-Notification-To:
: To: Albrecht Dreß <>
: Subject: MDN TEST
: Message-ID: <Pine.LNX.4.21.0103221748330.4676-100000@regulus.localdomain>
: MIME-Version: 1.0
: Content-Type: TEXT/PLAIN; charset=US-ASCII
: Status: O
: Content-Length: 9
: Lines: 1

and the output of a few debug lines in this routine [read as `address from
libbalsa_address_to_gchar' (at-part)] was:

: a: `' (
: b: `' ( equal!
: a: `albrecht@localhost.localdomain' (@localhost.localdomain)
: b: `' ( NOT equal!

So I *think* it should work as expected, right? The second compare failes as
"my" address is set to albrecht@localhost.localdomain, and only sendmail takes
care of replacing it by the "real" one. No idea how I could handle this case,
but IMO it goes beyond the tasks of balsa.

> > * I would like to set the charset in the reply correctly, but
> >   different from the normal send operation I have no idea what the
> >   user selected the last time (and this might be incorrect). As a
> >   simple solution I could use gnome_i18n_get_language() to find the
> >   correct charset in the locales array of src/sendmsg-window.c (and
> >   use find_locale_index_by_locale), but then there would be bigger
> >   changes. Currently I use ISO-8859-1, but do you have an idea to
> >   improve this? 
> I am not sure if there is optimal solution. The best choice IMO would be
> to use the charset of the mail that contains the MDN request. Hm...

The problem is that both the sender address and the first part of the MDN
could contain national characters in the recipient's name, like the `ß' in

: The message sent on 22.03.2001 17:48:53 to Albrecht Dreß...

As it is likely that the user selected a charset which is able to display
her/his name correctly, I would opt for the locale solution. What do you

> IMO, it is best to send translation stuff to translation teams.

Hmmm, can you give me a pointer?

> Thanks a lot!

I have to thank you... balsa is such a nice program, and I *never* missed the
Netscape Messenger since I moved!


    Albrecht Dreß  -  Monschauer Straße 22  -  D-53121 Bonn (Germany)
      Phone (+49) 228 6199571  -  E-Mail

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]