Re: IMAP folders [brian@stafford.uklinux.net]

[Peter Bloomfield <bloomfld eos ncsu edu>]

On 2001.06.18 13:46 Pawel Salek wrote:
> I can only say that present CVS works for me(TM) and for Peter
> Bloomfield (I guess)...
> 
> /pawel

Thank you, Pawel: yes, it does work for me--I was beginning to wonder if my
setup is the only one it does work for!  Does anyone else have success or
failure to report?

Following Brian's suggestion, I turned off -Wno-uninitialized, and found 8
files that gcc didn't like.  Most weren't errors, with for instance
g_assert_not_reached() to catch the only path where a variable remained
uninitialized, but some appeared to be typos.  None was in my code :-), and
none appeared to bear on Brian's lack of messages.

The first attached patch reflects some wild guesses on my part as to how to
fix the typos.  The second patch adds some (hoepfully benign)
initialization to keep gcc quiet, in the cases where there didn't appear to
be an error.  Just suggestions...

Peter
diff -Naur balsa/libbalsa/address-entry.c balsa-temp/libbalsa/address-entry.c
--- balsa/libbalsa/address-entry.c	Tue May 15 05:46:37 2001
+++ balsa-temp/libbalsa/address-entry.c	Mon Jun 18 13:41:50 2001
@@ -608,7 +608,7 @@
     gchar *str;
 
     if (addy->match)
-        str = g_strconcat(str, addy->user, " (", addy->match, ")", NULL);
+        str = g_strconcat(addy->user, " (", addy->match, ")", NULL);
     else
 	str = g_strdup(addy->user);
     return str;
@@ -1959,7 +1959,7 @@
     
     g_return_if_fail(address_entry != NULL);
     g_return_if_fail(LIBBALSA_IS_ADDRESS_ENTRY(address_entry));
-    g_return_if_fail(input != NULL);
+    g_return_if_fail(address_entry->input != NULL);
 
     /*
      * First, check if it expanded, and accept it.
diff -Naur balsa/src/balsa-app.c balsa-temp/src/balsa-app.c
--- balsa/src/balsa-app.c	Thu Jun 14 07:46:19 2001
+++ balsa-temp/src/balsa-app.c	Mon Jun 18 13:59:15 2001
@@ -97,7 +97,7 @@
      *
      * I probably overdid it, but this way the code worked first time...
      */
-    g_return_val_if_fail(node != NULL, FALSE);
+    g_return_val_if_fail(nd != NULL, FALSE);
     node = (BalsaMailboxNode *)nd->data;
     g_return_val_if_fail(BALSA_IS_MAILBOX_NODE(node), FALSE);
     mbox = node->mailbox;
@@ -638,11 +638,12 @@
     gpointer *ptr = g_list_nth_data( messages, 0); 
     gboolean ret;
     
-    if(ptr)
-	orig = ((LibBalsaMessage *)ptr)->mailbox;
     ret = libbalsa_messages_move( messages, dest );
-    gtk_signal_emit_by_name( GTK_OBJECT(orig), "set-unread-messages-flag", 
+    if(ptr) {
+	orig = ((LibBalsaMessage *)ptr)->mailbox;
+        gtk_signal_emit_by_name( GTK_OBJECT(orig), "set-unread-messages-flag", 
 			     0, balsa_app.mblist);	
+    }
     gtk_signal_emit_by_name( GTK_OBJECT(dest), "set-unread-messages-flag", 
 			     0, balsa_app.mblist);	
     return(ret);
diff -Naur balsa/src/balsa-index.c balsa-temp/src/balsa-index.c
--- balsa/src/balsa-index.c	Sun Jun 10 19:27:09 2001
+++ balsa-temp/src/balsa-index.c	Mon Jun 18 14:00:58 2001
@@ -1601,7 +1601,7 @@
     BalsaIndex* index;
 
     g_return_if_fail(widget != NULL);
-    g_return_if_fail(index != NULL);
+    g_return_if_fail(user_data != NULL);
 
     index = BALSA_INDEX (user_data);
     list = GTK_CLIST(index->ctree)->selection;
@@ -1646,7 +1646,7 @@
     BalsaIndex* index;
 
     g_return_if_fail(widget != NULL);
-    g_return_if_fail(index != NULL);
+    g_return_if_fail(user_data != NULL);
 
     index = BALSA_INDEX (user_data);
     list = GTK_CLIST(index->ctree)->selection;
diff -Naur balsa/libbalsa/mailbox_local.c balsa-temp/libbalsa/mailbox_local.c
--- balsa/libbalsa/mailbox_local.c	Fri Apr  6 07:34:31 2001
+++ balsa-temp/libbalsa/mailbox_local.c	Mon Jun 18 13:45:34 2001
@@ -164,7 +164,7 @@
 libbalsa_mailbox_local_set_path(LibBalsaMailboxLocal * mailbox,
 				const gchar * path)
 {
-    int i;
+    int i = 0;
 
     g_return_val_if_fail(mailbox, -1);
     g_return_val_if_fail(path, -1);
diff -Naur balsa/src/address-book-config.c balsa-temp/src/address-book-config.c
--- balsa/src/address-book-config.c	Fri Dec 22 14:25:44 2000
+++ balsa-temp/src/address-book-config.c	Mon Jun 18 13:49:44 2001
@@ -89,7 +89,7 @@
     AddressBookConfig *abc;
     GtkWidget *bbox;
     GtkWidget *button;
-    GtkWidget *page;
+    GtkWidget *page = NULL;
     gchar *name;
     gint num;
 
@@ -450,7 +450,7 @@
 static void
 next_button_cb(GtkWidget * button, AddressBookConfig * abc)
 {
-    GtkWidget *pixmap, *bbox, *page;
+    GtkWidget *pixmap, *bbox, *page = NULL;
     gint num;
 
     bbox = GNOME_DIALOG(abc->window)->action_area;
diff -Naur balsa/src/information-dialog.c balsa-temp/src/information-dialog.c
--- balsa/src/information-dialog.c	Mon Feb 19 06:52:50 2001
+++ balsa-temp/src/information-dialog.c	Mon Jun 18 14:06:01 2001
@@ -67,7 +67,7 @@
 void
 balsa_information(LibBalsaInformationType type, const char *fmt, ...)
 {
-    BalsaInformationShow show;
+    BalsaInformationShow show = 0;
     gchar *msg;
     va_list ap;
 
diff -Naur balsa/src/mailbox-node.c balsa-temp/src/mailbox-node.c
--- balsa/src/mailbox-node.c	Mon Jun 18 09:23:44 2001
+++ balsa-temp/src/mailbox-node.c	Mon Jun 18 14:07:36 2001
@@ -632,7 +632,7 @@
 static GNode*
 add_local_mailbox(GNode *root, const gchar * name, const gchar * path)
 {
-    LibBalsaMailbox *mailbox;
+    LibBalsaMailbox *mailbox = NULL;
     GNode *node;
     GtkType type;
 
diff -Naur balsa/src/sendmsg-window.c balsa-temp/src/sendmsg-window.c
--- balsa/src/sendmsg-window.c	Thu Jun 14 07:46:19 2001
+++ balsa-temp/src/sendmsg-window.c	Mon Jun 18 14:10:36 2001
@@ -542,7 +542,7 @@
 static gint
 find_locale_index_by_locale(const gchar * locale)
 {
-    int i, j, maxfit = -1, maxpos;
+    int i, j, maxfit = -1, maxpos = 0;
 
     if (!locale || strcmp(locale, "C") == 0)
 	return LOC_ENGLISH_POS;