Re: [xslt] Patch for xsl:sort lang support

[Roumen Petrov <bugtrack roumenpetrov info>]

Nick Wellnhofer wrote:
> Roumen Petrov wrote:
> > Please find patch that is first attempt to avoid build problem after 
> > recent commits related to xsltlocale.
> >
> > I'm not convinced that xsltlocale.c is correct for msvcrt:
> > The manuals show that rfc3066 language tags are supported but the 
> > current code ignore all of them.
>
> I took the language codes from here:
> http://msdn.microsoft.com/en-us/library/39cwe7zf(VS.80).aspx

10x. I see that the _create_locale is related to setlocale.

On this page http://msdn.microsoft.com/en-us/library/ms776260(VS.85).aspx
is listed another information but for other functions.
May be win32 locale has to be based on this.


> > Also I think that _create_locale is missing before msvcrt80. The 
> > proposed patch don't resolve this in makefile based win32 build.
>
> You're right, it seems it was introduced with VC8. Maybe it would be 
> best to have a configure switch to disable locale support in case you 
> want a build that runs without msvcr80.dll?

In the proposed patch configure will try detect presence of 
_create_locale if don't exist header xlocale.h , but not in makefile 
based build ( win32/Makefile.msvc ). May a new makefile 
win32/Makefile.msvcXX can ersolve problem.


> > I wonder why the implementation assume that if exist xlocale.h the 
> > charmap is ascii.
>
> Which charmap do you mean?

EBCDIC


> Nick

Roumen