Re: [xslt] Patch for xsl:sort lang support

Daniel Veillard wrote:
On Tue, Jun 03, 2008 at 10:40:53PM +0300, Roumen Petrov wrote:
Nick Wellnhofer wrote:
Daniel Veillard wrote:
On Thu, May 15, 2008 at 02:46:17PM +0200, Nick Wellnhofer wrote:
 Okay, thanks !
I finally took the time to apply your patch (no I hadn't forgotten :-)
it's now in SVN !
Just one thing, it would be nice to add a couple of simple example
to test taht this is working correctly in the regression tests, if you
have some that would be a good addition.
Yes, I had a test case in the first patch I sent. But you need to have the required locales installed with locale-gen on some systems, otherwise the tests won't work. I don't know if this is a problem.

Another thing I'm not sure about is the configure check. Maybe it would be better to use AC_TRY_COMPILE instead of AC_TRY_RUN here?
AC_TRY_COMPILE is preferred in cross-compilation environment.
Also instead AC_TRY_RUN we may prefer AC_RUN_IFELSE.

 hum, good point, maybe we should stick to AC_TRY_COMPILE indeed,


Please find patch that is first attempt to avoid build problem after recent commits related to xsltlocale.

I'm not convinced that xsltlocale.c is correct for msvcrt:
The manuals show that rfc3066 language tags are supported but the current code ignore all of them. Also I think that _create_locale is missing before msvcrt80. The proposed patch don't resolve this in makefile based win32 build.

I wonder why the implementation assume that if exist xlocale.h the charmap is ascii.


Attachment: libxslt-trunk-20080608.patch.gz
Description: application/gzip

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]