Re: [xslt] linking of libexslt

[Graham Wilson <bob decoy wox org>]

On Mon, Oct 20, 2003 at 02:43:44AM -0400, Daniel Veillard wrote:
> > Also, there is code in libexslt's Makefile.am (although it is commented
> > out) which links libexslt against the recently-built libxslt, instead of
> > the system libxslt. Why is this commented out? Isn't this the right way
> > to do it?
> 
>   Because dependancies between "being built" libraries is a problem in
> practice. It is very likely that I did so to ensure that the common case
> I can test and debug and must have working do indeed work.
>   I takes patches about configure/Makefile and shared libraries but with
> a lot of caution, because usually I get patches which work for the platform
> or the use case for which the person was interested in but tend to break
> othert setups. It is extremely hard to assess that there is no regression
> in configure/Makefile patches.

I have applied the attached patch to the Debian libxslt package, and it
sucessfully compiles on 11 different (Linux) architectures.

-- 
gram
Index: configure.in
===================================================================
--- configure.in	(revision 25)
+++ configure.in	(working copy)
@@ -386,22 +386,6 @@
 AC_SUBST(CPPFLAGS)
 AC_SUBST(LDFLAGS)
 
-#
-# Some fun with prelinking :-(
-# try to check if there is already an installed shared lib of the same level
-#
-INSTALLED_XSLT_LIB=""
-if test -d $prefix
-then
-    shared_xslt_lib="$prefix/lib/libxslt.so.$LIBXSLT_MAJOR_VERSION"
-    shared_xslt_la="$prefix/lib/libxslt.la"
-    if test -f $shared_xslt_lib -a -f $shared_xslt_la
-    then
-	INSTALLED_XSLT_LIB="-L$libdir -lxslt"
-    fi
-fi
-AC_SUBST(INSTALLED_XSLT_LIB)
-
 dnl
 dnl In build tree I use a static version with memory debug enabled
 dnl
Index: libexslt/Makefile.am
===================================================================
--- libexslt/Makefile.am	(revision 25)
+++ libexslt/Makefile.am	(working copy)
@@ -25,10 +25,8 @@
 	libexslt.h			\
 	dynamic.c
 
-# The following DOES NOT WORK reliably. Sorry no prelinking to uninstalled
-# yet libraries.
-# libexslt_la_LIBADD = $(top_builddir)/libxslt/libxslt.la $(EXTRA_LIBS)
-libexslt_la_LIBADD = $(INSTALLED_XSLT_LIB) $(EXTRA_LIBS)
+# The following DOES NOT WORK reliably.
+libexslt_la_LIBADD = $(top_builddir)/libxslt/libxslt.la $(EXTRA_LIBS)
 libexslt_la_LDFLAGS = -version-info @LIBEXSLT_VERSION_INFO@
 
 man_MANS = libexslt.3
Index: breakpoint/Makefile.am
===================================================================
--- breakpoint/Makefile.am	(revision 25)
+++ breakpoint/Makefile.am	(working copy)
@@ -5,7 +5,7 @@
 libxsltbreakpoint_la_SOURCES = 	\
 	deprecated.c
 
-libxsltbreakpoint_la_LIBADD = $(INSTALLED_XSLT_LIB)  $(EXTRA_LIBS)
+libxsltbreakpoint_la_LIBADD = $(top_builddir)/libxslt/libxslt.la $(EXTRA_LIBS)
 libxsltbreakpoint_la_LDFLAGS = -version-info @LIBXSLTBREAK_VERSION_INFO@
 
 clean:

Digital signature