Re: [xml] Availability of libxml2-2.9.4 release candidate 2 - regexp

[Pete Cordell <petexmldev codalogic com>]

On 09/05/2016 10:26, Daniel Veillard wrote:
>   Hi Pete,
>
> On Mon, May 09, 2016 at 10:02:28AM +0100, Pete Cordell wrote:
> > Thanks Daniel.  I've managed to verify that the ab?c{0,1} pattern now works.
> > But the following pattern still appears to fail:
> >
> > =>((2{1,2}|24)\.){2}2
> > #fails
> > 24.24.2
>
>   Right, I gave it 30mn, looked at the graph buildup, epsilon transition
> and state reduction, and then the advance through the state machine
> (it's a non-determinist one with rollbacks) and somehow the rollback to pick
> 24 instead of 2{1,2} works in the first 24. occurence but not the second
> one, didn't finished and decided to let this for after the rc2 release

Rather you than me :-)  Thanks for trying.  I mainly wanted to make sure 
that you hadn't missed it as it was buried at the end of a message after 
quite a lot of noise!

> > Also, I see you haven't had a chance to put the test vectors in the
> > test/regexp dir.  If you let me know what form you'd like them in I could
> > submit something as a patch / copy of files / whatever.
>
>   a git diff with the new tests and results would be great if you can
> provide it :-)

Is this OK?  I used git format-patch.  I'm new to submitting diffs!  If 
you want another format let me know.

---------------------

Date: Mon, 9 May 2016 11:08:26 +0100
Subject: [PATCH] Additional regexp test vectors

---
 test/regexp/multiple-rollback-paths |  3 +++
 test/regexp/optional-as-zero-one    | 15 +++++++++++++++
 2 files changed, 18 insertions(+)
 create mode 100644 test/regexp/multiple-rollback-paths
 create mode 100644 test/regexp/optional-as-zero-one

diff --git a/test/regexp/multiple-rollback-paths 
b/test/regexp/multiple-rollback-paths
new file mode 100644
index 0000000..98bc5c3
--- /dev/null
+++ b/test/regexp/multiple-rollback-paths
@@ -0,0 +1,3 @@
+=>((2{1,2}|24)\.){2}2
+#fails
+24.24.2
diff --git a/test/regexp/optional-as-zero-one 
b/test/regexp/optional-as-zero-one
new file mode 100644
index 0000000..0c696f1
--- /dev/null
+++ b/test/regexp/optional-as-zero-one
@@ -0,0 +1,15 @@
+=>ab?c{0,1}
+a
+ab
+abc
+ac
+=>ab?c?
+a
+ab
+abc
+ac
+=>ab{0,1}c{0,1}
+a
+ab
+abc
+ac
--
2.5.3.windows.1

-----------------------

Thanks again,

Pete.