Re: [xml] [PATCH] Windows build fixes

On Wed, 19 Sep 2012, Roumen Petrov wrote:

This is because HAVE_CONFIG_H is not #defined, which is odd, because configure.js goes to the trouble of creating a config.h file.

No please do not introduce again HAVE_CONFIG_H .
Please fix the test as in

How should this be fixed? MSVC7.1 has "_vsnprintf", not "vsnprintf". How do you want to redirect "vsnprintf" in the code to "_vsnprintf" at link time?

(Note: The above names are actually "_vsnprintf" and "__vsnprintf" as far as the linker is concerned, thanks to Microsoft convention.)

I don't think getting rid of config.h for Win32 builds is a good idea, because then you no longer have a common place to put in workarounds for the Windows code environment. The leading underscore on vsnprintf() is just one example of many.


Daniel Richard G. || danielg teragram com || Software Developer
Teragram Linguistic Technologies (a division of SAS)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]