Re: [xml] [PATCH] Windows build fixes

[Roumen Petrov <bugtrack roumenpetrov info>]

Daniel Richard G. wrote:
> On Wed, 19 Sep 2012, Roumen Petrov wrote:
>
> > > This is because HAVE_CONFIG_H is not #defined, which is odd, because 
> > > configure.js goes to the trouble of creating a config.h file.
> >
> > No please do not introduce again HAVE_CONFIG_H .
> > Please fix the test as in 
> > https://bugzilla.gnome.org/show_bug.cgi?id=681228
>
> How should this be fixed? MSVC7.1 has "_vsnprintf", not "vsnprintf". 
> How do you want to redirect "vsnprintf" in the code to "_vsnprintf" at 
> link time?
>
> (Note: The above names are actually "_vsnprintf" and "__vsnprintf" as 
> far as the linker is concerned, thanks to Microsoft convention.)

> I don't think getting rid of config.h for Win32 builds is a good idea, 
> because then you no longer have a common place to put in workarounds 
> for the Windows code environment. The leading underscore on 
> vsnprintf() is just one example of many.
You could find answer in past discussions . Please search the list.
You cannot build library if vsnprintf is not redefined to _vsnprintf. 
Please double check, as out build fail in test... so ?

> --Daniel

Roumen