Re: [xml] The issue around LoadLibrary on Windows

[Csaba Raduly <rcsaba gmail com>]

On Wed, May 23, 2012 at 8:58 PM, Michael Ludwig  wrote:
> Csaba Raduly schrieb am 23.05.2012 um 14:34 (+0200):
>
> > xmlModuleOpen and its worker, xmlModulePlatformOpen take a const
> > char*, not const xmlChar*. This suggests that the parameter is not
> > UTF-8, in which case libxml2 should just use LoadLibraryA. This would
> > work as long as the entire path of the library is made of ASCII
> > characters.
>
> And that means it would break otherwise. And on all NT systems (as
> opposed to 95/98/ME), LoadLibraryA calls LoadLibraryW internally.

Of course it does (after converting from narrow to wide strings), so
libxml2 might just as well cut out the middle man, declare
xmlModuleOpen/xmlModulePlatformOpen to take a xmlChar* to an UTF-8
string, convert it itself with MultiByteToWideChar(CP_UTF8), and call
LoadLibraryW. This would give wider functionality on WIndows; I
believe Linux can also handle UTF-8 nowadays.

Csaba
-- 
GCS a+ e++ d- C++ ULS$ L+$ !E- W++ P+++$ w++$ tv+ b++ DI D++ 5++
The Tao of math: The numbers you can count are not the real numbers.
Life is complex, with real and imaginary parts.
"Ok, it boots. Which means it must be bug-free and perfect. " -- Linus Torvalds
"People disagree with me. I just ignore them." -- Linus Torvalds