Re: [xml] The issue around LoadLibrary on Windows



* Daniel Veillard wrote:
 C.f. the bug Fix windows unicode build
 https://bugzilla.gnome.org/show_bug.cgi?id=638650

and the previous discussions here:

 http://mail.gnome.org/archives/xml/2008-February/msg00094.html

now that the release is done, can we have a final decision on this.
As I understand it, LoadLibraryW takes a wchar_t* parameter, while
internally we are using only a char * (or xmlChar *) so it makes
no sense to try to call LoadLibraryW, and instead of using the
macro LoadLibrary which can only break build, calling LoadLibraryA
seems to be the simplest.

It is not clear to me that building libxml2 with UNICODE defined is a
sound idea if libxml2 is not designed for that, but apart from that I
would agree, if the idea is that `xmlModulePlatformOpen` takes some
platform string you know nothing about, as opposed to, say, xmlChar*,
which you would know is a UTF-8 text string.
-- 
Björn Höhrmann · mailto:bjoern hoehrmann de · http://bjoern.hoehrmann.de
Am Badedeich 7 · Telefon: +49(0)160/4415681 · http://www.bjoernsworld.de
25899 Dagebüll · PGP Pub. KeyID: 0xA4357E78 · http://www.websitedev.de/ 



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]