Re: [xml] PATCH: XPOINTER and friends

[Daniel Veillard <veillard redhat com>]

On Tue, Oct 10, 2006 at 10:31:04AM -0500, Ross J. Reedstrom wrote:
> On Tue, Oct 10, 2006 at 04:38:13AM -0400, Daniel Veillard wrote:
> >   The patch looks just fine to me, I applied it and commited it to CVS,
> > thanks a lot !
>
> Hey, just doing our open source bit.

  :-)

> > > A student working with us even coded up some tests, which I've attached
> > > as well: they need to be dropped in python/tests. They may need fixing
> > > up to match your test machinery. Right now, they're a bit chatty.
> >
> >   Right the test as is can't really be commited since it breaks the no output
> > assumption of 'make tests' in python. Basically the python code would have
> > to embbed the logic of checking the output, instead of relying on the user
> > to garantee it's correct (and honnestly it's really not trivial). Can you
> > please fix tstxpointer.py to work that way and send it back ?
> > I also had to roll back the python/test/Makefile.am change to not reference
> > tstxpointer.py since I can't commit it as is.
>
> I've copied Stefan on this note: He'll clean up the tests and resubmit.

  okay thanks. Checking for the type of the returned objects and their size
if not strings should in general be sufficient to assert that the result is
correct.

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/