Re: [xml] PATCH: XPOINTER and friends

On Tue, Oct 10, 2006 at 04:38:13AM -0400, Daniel Veillard wrote:

  The patch looks just fine to me, I applied it and commited it to CVS,
thanks a lot !

Hey, just doing our open source bit.

A student working with us even coded up some tests, which I've attached
as well: they need to be dropped in python/tests. They may need fixing
up to match your test machinery. Right now, they're a bit chatty.

  Right the test as is can't really be commited since it breaks the no output
assumption of 'make tests' in python. Basically the python code would have
to embbed the logic of checking the output, instead of relying on the user
to garantee it's correct (and honnestly it's really not trivial). Can you
please fix to work that way and send it back ?
I also had to roll back the python/test/ change to not reference since I can't commit it as is.

I've copied Stefan on this note: He'll clean up the tests and resubmit.

Ross Reedstrom, Ph.D.                                 reedstrm rice edu
Research Scientist                                  phone: 713-348-6166
The Connexions Project            fax: 713-348-3665
Rice University MS-375, Houston, TX 77005
GPG Key fingerprint = F023 82C8 9B0E 2CC6 0D8E  F888 D3AE 810E 88F0 BEDE

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]