Re: [xml] Potential wrong usage of xmlIsID() in tree.c



On Fri, Feb 24, 2006 at 05:18:09PM -0500, Rob Richards wrote:
A lot of the code can be elimintated using existing functionality, such 
as what's the different between the xmlGetProp functions and just 
xmlHasNsProp or xmlTreeNewPropRaw and xmlNewDocProp?

  yes please :-) , I'm guilty too of copy/paste feel free to fix !

The one question I have regards the function signatures. I'm assuming 
that the ones with leading comments are the ones to be exposed 

  The rule is that anything exported from an header in include/libxml
must have a complete comment header, as it's used for the doc extraction.
I also prefer to have *all* function even static ones commented that
way.

Daniel

-- 
Daniel Veillard      | Red Hat http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]