Re: [xml] Problems with file names in UTF-8 on Windows

[Daniel Veillard <veillard redhat com>]

On Wed, Aug 16, 2006 at 04:58:00PM +0200, Roland Schwingel wrote:
> Hi...
>
> > > The utf-8 support for Windows was my idea and my patch, so I feel 
> > > responsible for the problems
> > > [...]
> > > > > OS (bug #346367).
> > > Ok.. I will adress that, too. Did not know that there is a bug report.
> > >
> > > At present I am awfully busy, but I hope I can supply my revised patch 
>
> > > (based
> > > on libxml 2.6.26) by beginning of next week.
> > >
> > > I hope this will solve all problems with win9x and non utf-8 encoding 
> > > without
> > > adding new api. Would this be ok for everyone?
> >
> >   That sounds excellent to me. I didn't expect a new release within a 
> > couple of weeks so even if it takes a bit of time it is not a big deal,
> >
> > Daniel
>
> Here comes my revised/extended patch.

  To follow a good tradition, it seems you forgot the patch :-)
I do that all the time too !

> What is the state now:
> In the case that a path cannot be accessed on disk asuming the path to be 
> in
> utf-8 on windows, it is also tried with native encoding now as fallback. 
> That should
> fix the first part.
>
> Because of win9x compatibility it is now decided on runtime whether a 
> system
> is capable of calling _wstat()/_wfopen(). If the system is not capable 
> doing it,
> my utf-8 part is invisible. This should also fix bug #346367. But well, I 
> do not
> have a win9x installation so I implemented it blind but it *should*really* 
> work.

  Sounds like famous last words :-) well I expect people with win9x to try it
out !

> (OT: Is win9x nowadays really of any relevance for professional 
> applications? 
>  We dropped support for it several years ago, and nobody really 
> complained. But this
>  is a different discussion, but someday libxml2 should IMO also declare 
> End-Of-Life
>  for win9x.)

  You know we have code in there for VMS and MVS, somehow portability even
to older platform is a tradition here.

> When doing the patch I found 2 static functions in xmlIO.c doing quite the 
> same thing.
> xmlSysIDExists() and xmlNoNetExists(). In favour of simplicity I decided 
> to discard xmlSysIDExists().

  As long as static and identical, fine by me

> So I hope this resolves all pending issues. Feel free to reply in case of 
> any problems.

  yup, can we get that sweet patch ;-) ?

Daniel

-- 
Red Hat Virtualization group http://redhat.com/virtualization/
Daniel Veillard      | virtualization library  http://libvirt.org/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine  http://rpmfind.net/