Re: [xml] missing check in tree.c?

[Daniel Veillard <veillard redhat com>]

On Fri, Jul 30, 2004 at 10:28:02AM +0200, oliverst online de wrote:
> in tree.c line 3850 (libxml2-2.6.11) you find this code:
>
>     /* if parent != NULL we already registered the node above */
>     if (parent == NULL && xmlRegisterNodeDefaultValue)
>       xmlRegisterNodeDefaultValue((xmlNodePtr)ret); 
>
> I recognised, that where the xmlRegisterNodeDefaultValue is also used
> and the code always looks like this:
>
> if ((__xmlRegisterCallbacks) && (xmlRegisterNodeDefaultValue))
>
> Is there is this additional check for __xmlRegisterCallbacks missing?

  Right, fixed. This is to avoid the penalty of a thread related call when
no callback has been registered,

  thanks !

Daniel

-- 
Daniel Veillard      | Red Hat Desktop team http://redhat.com/
veillard redhat com  | libxml GNOME XML XSLT toolkit  http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/