Re: libxml on OpenVMS (was RE: [xml] Release of libxml2-2.5.7)

["Craig A. Berry" <craigberry mac com>]

At 2:10 PM +0000 4/26/03, Bjorn Reese wrote:
> "Craig A. Berry" wrote:
>
> > -# if (__CRTL_VER > 80000000)
> > +# if (__CRTL_VER < 80000000)
>
> This change is wrong.

Well, at least it prevents us from saying that the current latest
version of the library (70300022) has complete C99 support when it
doesn't.

> See the comment that follows the #if; especially the last three lines:
>
> /*
> * Although the compiler supports C99 language constructs, the C
> * run-time library does not contain all C99 functions.
> *
> * This was the case for 70300022. Update the 80000000 value when
> * it has been accurately determined what version of the library
> * supports C99.
> */

But also read the code that follows the comment:

#  if defined(TRIO_COMPILER_SUPPORTS_C99)
#   undef TRIO_COMPILER_SUPPORTS_C99
#  endif

The point of this block is that for C run-time versions *less* than
some future version, we have to override the compiler's claim of C99
support that it thinks it has.

> A better workaround would be to change the value to 90000000.

Hopefully some future version of the library -- and hopefully closer
to 80000000 than 90000000 -- will finish those few missing bits.  I'm
not sure the number matters much, but I do still think the direction
of comparison was wrong before my patch.
-- 
________________________________________
Craig A. Berry
mailto:craigberry mac com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser