Re: [xml] patch for SAX.c
- From: Daniel Veillard <veillard redhat com>
- To: Anthony Jones <amj30 cam ac uk>
- Cc: xml gnome org
- Subject: Re: [xml] patch for SAX.c
- Date: Sun, 20 Jan 2002 15:46:00 -0500
On Sun, Jan 20, 2002 at 08:35:52PM +0000, Anthony Jones wrote:
In the function startElement() we use a fixed length buffer when checking
that attributes are not declared. Unless I'm missing something, I think we
should really use a dynamically allocated buffer, so we don't get problems
in the unlikely event that strlen(prefix) + strlen(":") + strlen(name) >
99. Doing it this way also means we stick with using the xmlStr functions,
which is nicer than using snprintf() IMHO...
Agreed, this was ugly ! I applied the patch without troubles,
thanks !
Daniel
--
Daniel Veillard | Red Hat Network https://rhn.redhat.com/
veillard redhat com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]