Re: [Utopia] gnome-vfs patch, take one

[David Zeuthen <david fubar dk>]

On Thu, May 13, 2004 at 10:51:42AM -0400, John (J5) Palmieri wrote:
> On Wed, 2004-05-12 at 17:16, David Zeuthen wrote:
> > On Wed, 2004-05-12 at 17:14 -0400, John (J5) Palmieri wrote:
> > > Worked almost perfectly for me.  One problem I am having is that I lose
> > > my kudzu mounts:
> > > 
> > > /dev/cdrom              /mnt/cdrom              udf,iso9660
> > > noauto,owner,kudzu,ro 0 0
> > > /dev/fd0                /mnt/floppy             auto   
> > > noauto,owner,kudzu 0 0
> > > 
> > > They show up in fstab but not in nautilus.  Just wondering if you might
> > > have a clue as to why this would be.
> > > 
> > 
> > Oh, that's a feature really! The idea is, and I should have written that
> > along with the patch, only to show the actual volumes that is mounted. I
> > think this is sound because g-v-m will automount media.
> 
> Devils Advocate - But what if someone has automount off?
> 

But this is already working even if you mount it yourself - remember,
the HAL daemon monitors /etc/mtab to maintain the properties
block.is_mounted and block.mount_point. So the second you mount your
media from e.g. the commandline HAL finds out, then gnome-vfs finds
out, Nautilus finds out (layers upon layers, yeah) and you get an icon
in computer:///

> Otherwise it seems like right thing to do.  I would just add that if
> someone has added their mount to fstab they would expect the unmounted
> volume to appear in "Computer".  How does this sound as a workable
> solution?  The hal mount script puts a hal flag (mount will need to be
> modified) with the mount in fstab.  Any entry in fstab that does not
> retain that flag reverts back to the old behavior.  This would fix the
> floppy problem.
> 

Yes, we probably want to add a 'hal' flag to mount much the same way
kudzu does. This will make fstab mgmt a whole lot easier.

But I see little point in showing icons for unmounted volumes, I mean
why should we in this patch assume g-v-m is not automounting media?
And if the use for some reason have disabled automounting, he should
be able to mount it himself from the commandline. That's my opinion
anyway..

Floppies, of course, need to be handled in a special way. IIRC there
were some discussion on how to access floppies through a gnome-vfs
method with what is essentially a userspace driver? With the benefit
that the user doesn't have to mount/unmount the disc? (and HAL can't
do it for him because of hardware limitations). But I can't remember
the specifics...

> > So if you put in a disc in your optical drive it will show up given you
> > installed the update-fstab.sh callout and have configured udev correctly
> > [1] - note that floppy disks aren't really supported yet.
> > 
> > Cheers,
> > David
> > 
> > 
> > [1] : There is, or were at least, an issue with udev on fc-devel; you
> > have to run udevstart or something manually to create all the nodes. See
> > RH bug #120605 for details.
> 
> After executing udevstart Nautilus now crashes when I try to open the
> "Computer" window.  It crashes when it gets to displaying the cdrom
> icon.  Backtraces are useless so I am going to dig into the Nautilus
> code to see what is going on. Also my menu no longer appears in the
> application menus.
> 

Yep, that patch is a bit flaky - I've improved a lot. I'll post the 
updated patch tonight. 

For example, blank and audio discs are showing up with an icon even
though they are not mounted (clicking on the blank disc will take you
to burn:/// and the audio disc will take you to cdda://<devname>). 

If you insert a mixed disc, then two icons are shown - just like on
another operating system.

Thanks,
David