Re: [Tracker] REVIEW: external-crawler branch, part3

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/08/2014 10:27, Philip Van Hoof wrote:
> b291f85416674b4b7a54cded5f6e6fe8af22d181
>
> +     if (!priv->root) { +            g_object_unref (priv->root); +  }
>
> Perhaps this got fixed afterwards in a later commit and I missed
> it, but it can't be right in this comment:
>
> if the thing is NULL, then unref it. Hmm? :-)

Aha you fixed this in aac6cf88391775f8db7cab9c47e10b9b72999c49

        g_node_destroy (priv->file_tree);

- -     if (!priv->root) {
+       if (priv->root) {
                g_object_unref (priv->root);
        }

Can you squash those two commits together before merging master?

Just git rebase -i, you know the drill ;-)


Kind regards,

Philip


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)

iQEcBAEBAgAGBQJT5JFGAAoJEEP2NSGEz4aDzyEH+wc6eYcLCoAQWpi9DPz+H2nI
44qMtmvic5cqLmn92p9LnuwEfPup4xPMz5VYZ1E2+h1WOSxPYgf6hGmSDKI64kMm
3KpXCgzj3tgNdnL49huTfJ1T5QDYg2VzG8vx8295BKGQvS3pE4nx0oLTJRqKujyr
RNAAerxzRF4EW0R7immn9EndYILueop2cGGU5rPYnT9K0sjNhcx6D5VuA/kpdP4z
PR1qMWkzV7HfPh32pNY5w0lxBl1YvWTxgAdkIHpQ+mKLxzx93UKAHYnY9XQkK6bz
8+kQHm4LdS3KuKaC75WKodmftfHU/fg6KXASoATOMGuWcYfuWtZ/mifY0mxthFg=
=bYtF
-----END PGP SIGNATURE-----