Re: [Tracker] REVIEW: external-crawler branch, part3

[Philip Van Hoof <philip codeminded be>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/08/2014 10:58, Philip Van Hoof wrote:
> On 8/08/2014 10:27, Philip Van Hoof wrote:

> Can you squash those two commits together before merging master?
>
> Just git rebase -i, you know the drill ;-)

8cdc0188e2c4d341e6e9788370e9381e085ae34b

- -     if (!priv->root) {
+       if (priv->root) {
                g_object_unref (priv->root);
        }

Ah and here also. Was there another location?

Also for that one, can you squash those commits? It helps with
git-bisecting and unit testing.


Kind regards,

Philip



> _______________________________________________ tracker-list
> mailing list tracker-list gnome org 
> https://mail.gnome.org/mailman/listinfo/tracker-list

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (MingW32)

iQEcBAEBAgAGBQJT5JIxAAoJEEP2NSGEz4aDW4MIAK7N04tWU5voprxL4zjzxza4
nhLo7APsAcM3FqROVL9zGdwL3npbQP7ITaePJAxBS12/AuM1eX8S91F0Ug+LsOhn
6bfxMgvvTEo1LTprNwhV3AhmNMmU8tXIjHSTT23yLvs7+JTjwR4ndTIYiU22P2CD
R7XslBvT/nBbhWb1hMGQVPpwSu/I3sh8te1fXJ0doGE64GdHonz2w17RYqbj57jE
Orjuh+1cbzA6nzRhI8+fnSlGwmWQogm0biUjpoewyiWrRD9kYEMxRttyxO8l7qVR
uvi7yBqnKwWwqM87Z+QuaPOvBCUocylgiCx6JSx4iRP1vlhK25yWQHol6OxjVzY=
=rzqQ
-----END PGP SIGNATURE-----