Re: [Tracker] REVIEW: external-crawler branch, part3

[Martyn Russell <martyn lanedo com>]

On 08/08/14 09:27, Philip Van Hoof wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> b291f85416674b4b7a54cded5f6e6fe8af22d181
>
> +       if (!priv->root) {
> +               g_object_unref (priv->root);
> +       }
>
> Perhaps this got fixed afterwards in a later commit and I missed it,
> but it can't be right in this comment:
>
> if the thing is NULL, then unref it. Hmm? :-)

Yea, I would fully suggest people use git diff origin/master (perhaps 
after a rebase), to see the real diff. The commits are good for 
reasoning of course.

I've seen this with massive branches from Carlos before - it can be 
confusing :)

--
Regards,
Martyn

Founder & Director @ Lanedo GmbH.
http://www.linkedin.com/in/martynrussell