Re: [Tracker] No contents indexing taking place

On Wed, 2012-03-07 at 10:50 +0000, Karl Relton wrote:
On Wed, 2012-03-07 at 10:45 +0000, Martyn Russell wrote:
For tracker-miner-web.c I am concerned by the comment at line 193:

/* No need to RequestName again as already done by the parent
TrackerMiner object */

Yes it is. The libtracker-miner library requests the name for you so 
assuming the library is done correctly, ALL miners should work properly.

As far as I can see the parent object in tracker-miner-object.c creates
the connection, registers its own interface, and then sets the name on
the bus ... and this happens before (AFAICT) the child object registers
its interface object.

So I would imagine that the web miner might not get all its interfaces
registered correctly.

Yea, I think you could be right here. Are you seeing problems with the 
web miners then?

One approach here might be to do the name request in _init() not 
_initable_init(), but that's quite a risky change to make at this late 
stage before we release.

I haven't got web miners installed at the moment. I'll see if I can
install it and prod it with dbus-send. That might take me a wee while

The only miner that uses tracker-miner-web.c in the current source tree
(as far as I can see) is the Flickr miner. So I compiled that and
started poking it.

It does indeed show the problematic behaviour we feared: i.e. initially
the interfaces/methods advertised in tracker-miner-object.c are OK, but
those advertised in tracker-miner-web.c do NOT appear immediately.
Walking up to an already running deamon is ok because by then everything
is up & running.

So if a user tried to connect to the Miner.Flickr service (e.g. using
the GetAssociationData method) they will be disappointed, getting the
unknown interface error.

As you say, the fix is not so easy, so I guess you may want to release
0.14 anyway and then think how best to guaruntee the interfaces come up.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]