Re: [Tracker] Request for review, branch multidisc-album

[Philip Van Hoof <spam pvanhoof be>]

On Wed, 2010-12-08 at 14:28 -0500, Ivan Frade wrote:
> Hi,
>
>  Some comments to that branch:
>
> 1. MusicAlbumDisc and albumDiscAlbum are missing a rdfs:comment
> explaining what they are

OK

> 2. Functional tests data doesn't build:
>     make[5]: Entering directory
> `/home/ivan/devel/upstream/tracker/tests/functional-tests/ttl'
> make[5]: *** No rule to make target `040-nmm_MusicAlbumDisc.ttl',
> needed by `all-am'. Stop.

This is caused by not doing make-distclean or git clean -xdf

You can also just remove the file that gets touched in the Makefile.am
to indicate that the cc/generator must run again.
 
> 3. Missing functional tests that cover the updated code (at least a
> small music file that outputs disc)

OK, I'll look into that tomorrow

> Regards,
>
> Ivan
>
> On Tue, Dec 7, 2010 at 8:33 AM, Philip Van Hoof <spam pvanhoof be>
> wrote:
>         http://git.gnome.org/browse/tracker/log/?h=multidisc-album
>         
>         --
>         
>         
>         Philip Van Hoof
>         freelance software developer
>         Codeminded BVBA - http://codeminded.be
>         
>         _______________________________________________
>         tracker-list mailing list
>         tracker-list gnome org
>         http://mail.gnome.org/mailman/listinfo/tracker-list

-- 


Philip Van Hoof
freelance software developer
Codeminded BVBA - http://codeminded.be