Re: [Tracker] Request for review, branch multidisc-album

[Ivan Frade <ivan frade gmail com>]

Hi,

 Some comments to that branch:

1. MusicAlbumDisc and albumDiscAlbum are missing a rdfs:comment explaining what they are

2. Functional tests data doesn't build:
    make[5]: Entering directory `/home/ivan/devel/upstream/tracker/tests/functional-tests/ttl'
make[5]: *** No rule to make target `040-nmm_MusicAlbumDisc.ttl', needed by `all-am'. Stop.
 
3. Missing functional tests that cover the updated code (at least a small music file that outputs disc)
 
Regards,

Ivan

On Tue, Dec 7, 2010 at 8:33 AM, Philip Van Hoof <spam pvanhoof be> wrote:

http://git.gnome.org/browse/tracker/log/?h=multidisc-album

--


Philip Van Hoof
freelance software developer
Codeminded BVBA - http://codeminded.be

_______________________________________________
tracker-list mailing list
tracker-list gnome org
http://mail.gnome.org/mailman/listinfo/tracker-list