On Fri, May 15, 2009 at 3:15 PM, Jürg Billeter <j bitron ch> wrote:
Thanks for the update. I've fixed one small issue (set battery_percentage before calling g_object_notify) and pushed it.
Cool, good catch. I've now attached another patch that adds the DeviceKit-power backend, which is preferred by default over HAL if it's available. You can change the default backend as you wish, but in Fedora we'll be using DK-p by default, and compiling out the HAL bits. It's a much simpler (and better IMHO) interface than when we are using HAL, as I hope you'll see. It also doesn't incorrectly define you being on battery with a wireless mouse inserted, and treats on UPS power as system low power. i.e. a much easier interface to not use incorrectly. It's been compile tested as much as possible, but I can't test trackerd as I'm now getting compile errors in unrelated areas in the codebase. I appreciate it is git master, so I'm not sure if you're too bothered. Anyway, my error is: tracker-data-query.c:466: error: ‘TrackerSparqlQuery’ undeclared (first use in this function) Patch invited for review and comments. Thanks. Richard.
Attachment:
tracker-add-devicekit-power-1.patch
Description: application/force-download