Re: [Tracker] [patch] split TrackerHal into TrackerStorage and TrackerPower and re-organise into backend

[Richard Hughes <hughsient gmail com>]

On Fri, May 15, 2009 at 1:14 PM, Jürg Billeter <j bitron ch> wrote:
> On line 488 in tracker-indexer.c there is one occurrence of
> tracker_power_get_battery_in_use left, needs to be fixed to not break
> the build.

Done, sorry about that.

> +       return (priv->battery_percentage > BATTERY_LOW_THRESHOLD);
>
> This should be less than, not greater than, I assume.

Agreed.

> The hal_battery_notify function needs to check whether the percentage
> change crosses the BATTERY_LOW_THRESHOLD and call g_object_notify if
> appropriate.

Agreed.

New patch attached for review. Thanks again.

Richard.

Attachment: tracker-fix-properties-2.patch
Description: application/force-download