Re: [Tracker] [patch] split TrackerHal into TrackerStorage and TrackerPower and re-organise into backend

[Jürg Billeter <j bitron ch>]

On Fri, 2009-05-15 at 14:11 +0100, Richard Hughes wrote:
> On Fri, May 15, 2009 at 1:14 PM, JÃrg Billeter <j bitron ch> wrote:
> > On line 488 in tracker-indexer.c there is one occurrence of
> > tracker_power_get_battery_in_use left, needs to be fixed to not break
> > the build.
>
> Done, sorry about that.
>
> > +       return (priv->battery_percentage > BATTERY_LOW_THRESHOLD);
> >
> > This should be less than, not greater than, I assume.
>
> Agreed.
>
> > The hal_battery_notify function needs to check whether the percentage
> > change crosses the BATTERY_LOW_THRESHOLD and call g_object_notify if
> > appropriate.
>
> Agreed.
>
> New patch attached for review. Thanks again.

Thanks for the update. I've fixed one small issue (set
battery_percentage before calling g_object_notify) and pushed it.

Thanks,
JÃrg