Re: [Tracker] [PATCH] fixing a _bad_ bug in tracker-handler.py

["Marcus Fritzsch" <fritschy googlemail com>]

On 8/5/07, Mikkel Kamstrup Erlandsen <mikkel kamstrup gmail com> wrote:
> [...]
>
> Cheers ,
>
> A few comments.
>
>  * I would probably use _("Launch blahblah") for the description. As is done
> in the native application handler in deskbar. Look in
> /usr/lib/deskbar-applet/handlers/programs.py the class
> GenericProgramMatch
>   * You can also check out how apps are launched from there
>  * Pay attention to the get_hash() method of said class. The returned value
> is used for deduplication of the result set in deskbar. So if you can return
> the same string as GenericProgramMatch tracker app matches will not show up
> as dupes if you have the programs handler activated.

Ah, new stuff to me. I'll check it out and resend a patch.

> Otherwise it looks fine.
> Cheers,
> Mikkel

 Thanks for the review, Marcus