Re: [Tracker] [PATCH] fixing a _bad_ bug in tracker-handler.py



On 8/5/07, jamie <jamiemcc blueyonder co uk> wrote:
On Thu, 2007-08-02 at 20:49 +0200, Mikkel Kamstrup Erlandsen wrote:
2007/8/2, Marcus Fritzsch <fritschy googlemail com>:
        Hey there...

        There was a pretty bad bug in tracker-handler.py which only
        pops up if
        one has so strange usage patterns as I do ;). A related
        problem was
        reported[1].

        If traker is running in a different session tracker-handler.py
        will be
        happy with its requirements but will actually fail to connect
        to
        tracker. The problem is solved by adding one more check to the
        requirements.

        The downside of this is, that tracker will be started, even if
        the
        tracker-handler will not be used.

        Cheers, Marcus

        [1] http://bugzilla.gnome.org/show_bug.cgi?id=403752

        PS: I am looking for 'how' to put apps into the handler, but
        haven't
        found it yet.

Where can I review this fix?

I am very skeptic about the idea that trackerd will be started even if
the handler is deactivated. It will be almost impossible for users to
tracker down why Tracker always starts up during the session
initialization.

Cheers,
Mikkel


PS: I wrote the current code to check the availability of tracker, and
I think that it should fix the bug you refer to - I might be mistaken
though, I received only little feedback from testers (positive
though). I think your issue is another bug..?


whats the status of this?

can I apply his patch or is there still a problem?

No decision yet.

Mikkel, I think the added error section can be left out, after all it
just prevents a misbehavior that no one other than me has ever seen.

I attached a slightly modified version w/o the bogus error check,
fixed the regex a bit and removed the (unknown) string. Mikkel, can
you check this one please?

What about the other legal field codes for the Exec value specified[1]?

Kind regards, Marcus

[1] http://standards.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.0.html#exec-variables

Attachment: tracker_deskbar-handler_update.patch
Description: Text Data



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]