Re: Patch: refresh parameter in get_folders forces a retrieve of folder structure
- From: Sergio Villar Senin <svillar igalia com>
- To: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Patch: refresh parameter in get_folders forces a retrieve of folder structure
- Date: Thu, 12 Mar 2009 19:23:56 +0100
Sergio Villar Senin escribiu:
> José Dapena Paz escribiu:
>> O Mér, 11-03-2009 ás 15:33 +0100, José Dapena Paz escribiu:
>>> Hi,
>>>
>>> This patch just makes get_folders with refresh parameter enabled fetch
>>> again the folder structure instead of using the cached one. This way we
>>> can show also newly created folders.
>> The old patch in fact spoils performance of the list store and folder
>> tree model, as there were some sync requests with refresh == TRUE. It
>> shouldn't be needed as we're doing a previous asynchronous request with
>> refresh = TRUE.
>>
>> So you should also apply this patch.
>
> Makes sense to me. But we're assuming that we have the whole structure
> refreshed as the children are retrieved now with refresh=FALSE.
We can get rid of this if we review the tree folder model and force it
to always use the async calls instead of the sync ones.
Br
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]