Re: Patch: refresh parameter in get_folders forces a retrieve of folder structure

[José Dapena Paz <jdapena igalia com>]

O Mér, 11-03-2009 ás 15:33 +0100, José Dapena Paz escribiu:
> 	Hi,
> 
> 	This patch just makes get_folders with refresh parameter enabled fetch
> again the folder structure instead of using the cached one. This way we
> can show also newly created folders.

	The old patch in fact spoils performance of the list store and folder
tree model, as there were some sync requests with refresh == TRUE. It
shouldn't be needed as we're doing a previous asynchronous request with
refresh = TRUE.

	So you should also apply this patch.

-- 
José Dapena Paz <jdapena igalia com>
Igalia

diff --git a/libtinymailui-gtk/tny-gtk-folder-list-store.c b/libtinymailui-gtk/tny-gtk-folder-list-store.c
index 4e29e4e..f3f09c1 100644
--- a/libtinymailui-gtk/tny-gtk-folder-list-store.c
+++ b/libtinymailui-gtk/tny-gtk-folder-list-store.c
@@ -122,7 +122,7 @@ recurse_folders_sync (TnyGtkFolderListStore *self,
 	TnyList *folders = tny_simple_list_new ();
 
 	/* TODO add error checking and reporting here */
-	tny_folder_store_get_folders (store, folders, self->query, TRUE, NULL);
+	tny_folder_store_get_folders (store, folders, self->query, FALSE, NULL);
 	iter = tny_list_create_iterator (folders);
 
 	if (parent_name == NULL)
diff --git a/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c b/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c
index 3fd429e..44b6ddd 100644
--- a/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c
+++ b/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c
@@ -120,7 +120,7 @@ recurse_folders_sync (TnyGtkFolderStoreTreeModel *self,
 	TnyList *folders = tny_simple_list_new ();
 
 	/* TODO add error checking and reporting here */
-	tny_folder_store_get_folders (store, folders, self->query, TRUE, NULL);
+	tny_folder_store_get_folders (store, folders, self->query, FALSE, NULL);
 	iter = tny_list_create_iterator (folders);
 
 	if (parent_name == NULL)