Re: Patch: set of fixes for Bodystruct backend

[José Dapena Paz <jdapena igalia com>]

El jue, 03-12-2009 a las 11:23 +0100, Sergio Villar Senin escribió:
> I just have one concern about patch #8. If I am right we're losing the
> decorated header in the case of using BS. That's not good because this
> won't allow us to do things like setting flags to a message that was
> opened using an URL instead of a TnyHeader.

	TnyCamelBsMsgHeader is only used for attached messages, and not for the
top message itself. The top message itself will always have directly the
TnyCamelHeader, so no decoration is needed.

> 
> Br
> 
> José Dapena Paz escribiu:
> > El lun, 30-11-2009 a las 19:17 +0100, Sergio Villar Senin escribió:
> >> Patch looks great at first sight. A couple of comments:
> >>
> >> 1) cachefile_get -> you have to free "filename" before assigning a new
> >> value to it in the if block.
> >> 2) tny_camel_bs_mime_part_is_fetched -> you have to free "pos_filename"
> >> before returning true
> > 
> > Fixed patches taking this into account.
> > 
> >> and a question
> >>
> >> tny_camel_bs_msg_header_get_flags -> why always cached ?
> > 
> > 	Because in bs we always assume that, if we have the bodystruct, we also
> > have the headers retrieved. And we don't assume any body as it's
> > explicitely retrieved on demand.
> > 
> > 	This time I've attached all the micropatches for review.
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list


-- 
José Dapena Paz <jdapena igalia com>
Igalia