Re: Patch: set of fixes for Bodystruct backend
- From: José Dapena Paz <jdapena igalia com>
- To: tinymail-devel-list gnome org
- Subject: Re: Patch: set of fixes for Bodystruct backend
- Date: Wed, 02 Dec 2009 11:01:39 +0100
El lun, 30-11-2009 a las 19:17 +0100, Sergio Villar Senin escribió:
> Patch looks great at first sight. A couple of comments:
> 1) cachefile_get -> you have to free "filename" before assigning a new
> value to it in the if block.
> 2) tny_camel_bs_mime_part_is_fetched -> you have to free "pos_filename"
> before returning true
Fixed patches taking this into account.
> and a question
> tny_camel_bs_msg_header_get_flags -> why always cached ?
Because in bs we always assume that, if we have the bodystruct, we also
have the headers retrieved. And we don't assume any body as it's
explicitely retrieved on demand.
This time I've attached all the micropatches for review.
José Dapena Paz <jdapena igalia com>
] [Thread Prev