Re: [PATCH 02/18] Give tny_folder_store_get_folders a refresh parameter

[Philip Van Hoof <spam pvanhoof be>]

Martin is right about these Rob,

Please fix those things in the patch before committing


On Fri, 2008-09-26 at 09:45 +0200, martin bonnin wrote:
> Hi,
> 
> This patch will not compile with -DDBC enabled.
> In tny_folder_store_refresh_async you'll at least have to remove the 
> 
> +    g_assert (list);
> +    g_assert (TNY_IS_LIST (list));
> +    if (query)
> +        g_assert (TNY_IS_FOLDER_STORE_QUERY (query));
> 
> And also I guess we'll have to replave :
> 
> g_assert (TNY_FOLDER_STORE_GET_IFACE (self)->get_folders_async!=
> NULL);
> 
> by
> 
> g_assert (TNY_FOLDER_STORE_GET_IFACE (self)->refresh_async!= NULL);
> 
> 
> More context: 
> 
> +void tny_folder_store_refresh_async (TnyFolderStore *self,
> TnyFolderStoreCallback callback, TnyStatusCallback status_callback,
> gpointer user_data)
> +{
> +#ifdef DBC /* require */
> +    g_assert (TNY_IS_FOLDER_STORE (self));
> +    g_assert (list);
> +    g_assert (TNY_IS_LIST (list));
> +    if (query)
> +        g_assert (TNY_IS_FOLDER_STORE_QUERY (query));
> +    g_assert (TNY_FOLDER_STORE_GET_IFACE (self)->get_folders_async!=
> NULL);
> +#endif
> +
> +    TNY_FOLDER_STORE_GET_IFACE (self)->refresh_async(self, callback,
> status_callback, user_data);
> +
> +#ifdef DBC /* ensure */
> +#endif
> +
> +    return;
> +}
>  
> Cheers,
> 
> -- 
> Martin
> 
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be