Re: Patch: add extra checks on saving/rewriting summary

[Philip Van Hoof <spam pvanhoof be>]

Approved

On Thu, 2008-09-25 at 16:36 +0200, José Dapena Paz wrote:
> 	Hi,
> 
> 	This patch simply adds a lot of extra checks to the process of saving
> the summary. There are some code paths I'm not sure we're checking
> return values enough. And a not detected rewrite, will imply loading the
> corrupt summary, and then, crashes with sigbus (obtained in this case
> for mmapping and accessing the range of memory out of the mmap file we
> would expect to get).
> 
> Changelog would be:
> * Adding extra checks on writing to summary on disk, to make sure we 
>   detect if summary save_rewrite process was complete, and then, we can
>   load again the summary or consider this corrupt.
> 


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be