Re: trivial patch for debian/control typo



I don't quite see the point of having a make-orig-source target. Isn't
the source created by default good enough? When the packages are based
on proper (pre-)releases, the whole problem goes away. For me it looks
a bit over-engineered, but probably I just don't see the use-case.

Which brings me on to versions. Why is version 1.0.0 used in
configure.in if it might be changed to 0.x one day? In my opinion it's
better to fix that or stick with 1.0.0~svn.... if the versions never
will be lowered.

The scripts itself look fancy enough, but they don't compile with me.
I think the problem is that ./autogen.sh always has exit status 1
which leads 'make' to back out.

Thomas is right about >= typo and mozilla build-deps. Well spotted!

Do you have a suggestion for how to split the libraries? One .so file
in each package and a corresponding -dev? What other things did you
miss in the -dev package?

2006/11/23, Philip Van Hoof <spam pvanhoof be>:
On Thu, 2006-11-23 at 23:09 +0100, Thomas Viehmann wrote:

Committed as I don't know a lot about debian packaging. In case it's
wrong, I hope more knowledgeable people will assist me in reviewing this
and telling me I should roll it back ;)



ps. I by default trust contributors competence in "contribution areas"
that I have less knowledge of (like debian packaging).

If somebody dislikes this stance of mine, please notify me that you want
to become maintainer of the specific "contribution area".

:-)


> >o this is what I had in mind. It suffers from me not knowing a good
> way
> to do cleanup in a make-target (removing the temp-dir), though.
> I'm decreasing the version number compared to the /debian/changelog in
> svn, maybe it would be a good idea not to have 1.0.0 in there (the
> current version will be greater than all 0.x releases)...
> So "debian/rules make-orig-source" called from the svn checkout's root
> directory will give a source package (*.{dsc,diff.gz,orig.tar.gz})
> that
> builds e.g. with pbuilder.
> I've not changed the packaging itself, I think some more stuff needs
> to
> be moved to the -dev package, and then there's your comments about
> splitting the packages.
>
> Oh, and I've added the mozilla build-dependencies (checked against
> Debian/unstable, but should be OK for testing as well).
>
> Kind regards
>
> T.
> --
> Thomas Viehmann, http://thomas.viehmann.net/
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (tinymail.make-orig-source.diff)
>
> Index: debian/control
> ===================================================================
> --- debian/control      (revision 1209)
> +++ debian/control      (working copy)
> @@ -2,7 +2,7 @@
>  Section: gnome
>  Priority: optional
>  Maintainer: Oystein Gisnas <oystein gisnas net>
> -Build-Depends: debhelper (>= 5), cdbs, dpkg-dev (>= 1.13.19),
> gtk-doc-tools (>= 1.0), libglib2.0-dev (>= 2.6), libgtk2.0-dev,
> libgnomevfs2-dev, libgnomeui-dev, libgnome-keyring-dev, libgconf2-dev,
> libnm-glib-dev
> +Build-Depends: debhelper (>= 5), cdbs, dpkg-dev (>= 1.13.19),
> gtk-doc-tools (>= 1.0), libglib2.0-dev (>= 2.6), libgtk2.0-dev,
> libgnomevfs2-dev, libgnomeui-dev, libgnome-keyring-dev, libgconf2-dev,
> libnm-glib-dev, libnss3-dev, libnspr4-dev, libxul-dev
>  Standards-Version: 3.7.2
>
>  Package: tinymail-gtk
> Index: debian/rules
> ===================================================================
> --- debian/rules        (revision 1209)
> +++ debian/rules        (working copy)
> @@ -2,3 +2,25 @@
>
>  include /usr/share/cdbs/1/rules/debhelper.mk
>  include /usr/share/cdbs/1/class/autotools.mk
> +
> +make-orig-source: TMPNAME:=$(shell mktemp -d)
> +make-orig-source: DATE:=$(shell date --iso)
> +make-orig-source: UPSTREAMVER:=0~svn-$(DATE)
> +make-orig-source:
> +       -make -f debian/rules make-orig-source-internal TMPNAME=
> $(TMPNAME) DATE=$(DATE) UPSTREAMVER=$(UPSTREAMVER)
> +       -rm -rf $(TMPNAME)
> +       rm $(CURDIR)/debian/make-orig-source-internal-temp.stamp \
> +         || (echo "Making the Debian source packag
--
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://www.pvanhoof.be/blog




_______________________________________________
tinymail-devel-list mailing list
tinymail-devel-list gnome org
http://mail.gnome.org/mailman/listinfo/tinymail-devel-list




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]