Re: [Setup-tool-hackers] Your recent changes in ximian-setup-tools

[Chema Celorio <chema ximian com>]

On 31 Jul 2001 00:39:34 +0200, Zbigniew Chyla wrote:
> On Mon, 2001-07-30 at 13:50:32, Chema Celorio wrote:
> 
> > please be carefull when doing such changes, specially so close to a
> > release. When if first saw this email i wanted you to reverse the patch,
> > but i am going to fix it since it is not that hard. If you don't see .c
> > file in POTFILES.in is because there are some directories that are not
> > beeing built so the .c files are not included in the tarball. This
> > change breaks the tarball because of that, the bad thing is that make
> > distcheck does not catches this errors.
> > 
> > I'll fix it.
> 
> Actually, Pablo reverted his patch shortly after my email.
> References to files inside disks/, display/, memory/, etc. existed before
> Pablo made his change. These files _were_ distributed, but some day you
> commented out few lines in src/Makefile.am. 

Yes, because we want to do a stable release of XST and we are only
including the stable tools.

> Now you removed these files
> from POTFILES.in and translators have lost a big part of their work.

The work is not lost, because of cvs history.

> Thank you very much.

I don't get it, pablo makes a mistake and you ask him to revert the
patch.
I do a mistake and you tell me "Thank you very much". I have reverted my
last comit. No work has been lost.

This was the comit :
http://cvs.gnome.org/bonsai/cvsquery.cgi?module=ximian-setup-tools&branch=HEAD&branchtype=match&dir=ximian-setup-tools&file=&filetype=match&who=chema&whotype=match&sortby=Date&hours=&date=explicit&mindate=07%2F30%2F01+15%3A23&maxdate=07%2F30%2F01+15%3A25&cvsroot=%2Fcvs%2Fgnome

and this is the revert :
http://cvs.gnome.org/bonsai/cvsquery.cgi?module=ximian-setup-tools&branch=HEAD&branchtype=match&dir=ximian-setup-tools&file=&filetype=match&who=chema&whotype=match&sortby=Date&hours=&date=explicit&mindate=07%2F30%2F01+21%3A37&maxdate=07%2F30%2F01+21%3A39&cvsroot=%2Fcvs%2Fgnome 
regards,
Chema



_______________________________________________
setup-tool-hackers maillist  -  setup-tool-hackers@ximian.com
http://lists.ximian.com/mailman/listinfo/setup-tool-hackers