Re: Themes for 3.0

[Christopher Roy Bratusek <zanghar freenet de>]

Am Sun, 3 Oct 2010 07:56:24 +0200
schrieb fuchur <flohtransporter gmail com>:

> Hi,
> 
> On Sat, 2 Oct 2010 16:36:57 +0200
> wrote Christopher Roy Bratusek <zanghar freenet de>:
> 
> > ...
> >	- dark-tabbed (ultimate-best would be all four merged into on) ;;; Fuchur?
> > ...
> 
> It is many work to merged all in one. All four themes have different
> buttons/frames. If you want to put it in one you get a very large theme.jl file. 

> Secondly to remember which window has the titlebar on
> left/right/top/bottom you need a new "Window Properties"
> (http://home.avvanta.com/~sand/sawfish/v0.12/sawfish/Standard-Properties.html#Standard-Properties)
> and add a drop-down box in windows rules.  

see the attached patch and (window-get window 'frame-position), the second hunk is
optional, but in that case recommended, I think.

wouldn't it be possible, to check for frame-position (if none, then top) to load
theme-frame-position.jl, eg: theme-left.jl or theme-bottom.jl. rather than making a huge
theme.jl.

> No other themes use title bar on side/bottom. Nobody has build such a
> themes, so nobody need/want it (look at the vote at this list and the
> themes onto the wiki). Only for one or two themes add the above
> describes settings, i don't now.

As you see, it's a simple one-liner (on Sawfish-side).

> It is no problem to use Dark/Smootly Tab as stand alone theme, and if someone want
> left/right/bottom themes it can add in custom themes folder.

That would be an alternative.

Chris

diff --git a/lisp/sawfish/wm/ext/match-window.jl b/lisp/sawfish/wm/ext/match-window.jl
index 2fa9421..8b9bfef 100644
--- a/lisp/sawfish/wm/ext/match-window.jl
+++ b/lisp/sawfish/wm/ext/match-window.jl
@@ -91,6 +91,7 @@
                                 `(choice ,@(mapcar car match-window-types))))
                  (frame-style ,(lambda ()
                                  `(symbol ,@(find-all-frame-styles t))))
+		 (frame-position (choice left top right bottom))
 		 (dimensions (pair (number 1) (number 1)))
 		 (maximized (choice all vertical horizontal
 				    fullscreen full-xinerama))
diff --git a/lisp/sawfish/wm/ext/window-history.jl b/lisp/sawfish/wm/ext/window-history.jl
index 4746f00..015275b 100644
--- a/lisp/sawfish/wm/ext/window-history.jl
+++ b/lisp/sawfish/wm/ext/window-history.jl
@@ -74,7 +74,7 @@
   ;; list of states in window-state-change-hook that should be tracked
   (defvar window-history-states '(sticky ignored never-focus type maximized
                                          frame-style cycle-skip
-                                         window-list-skip))
+                                         window-list-skip frame-position))
 
   ;; property matched on
   (defvar window-history-key-property '(WM_CLASS WM_WINDOW_ROLE))